Commit 5d98f6a4 authored by Lee Jones's avatar Lee Jones Committed by Greg Kroah-Hartman
Browse files

staging: net: wimax: i2400m: fw: Fix some function header misdemeanours 



Fixes the following W=1 kernel build warning(s):

 drivers/net/wimax/i2400m/fw.c:584: warning: Function parameter or member 'i2400m' not described in 'i2400m_bm_cmd'
 drivers/net/wimax/i2400m/fw.c:584: warning: Excess function parameter 'returns' description in 'i2400m_bm_cmd'
 drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member 'chunk' not described in 'i2400m_download_chunk'
 drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
 drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf' description in 'i2400m_download_chunk'
 drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf_len' description in 'i2400m_download_chunk'
 drivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member 'flags' not described in 'i2400m_dev_bootstrap'

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20201112131959.2213841-4-lee.jones@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 80594fb4

drivers/staging/wimax/i2400m/fw.c

+11 −3
Original line number Diff line number Diff line
@@ -534,6 +534,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode, 
/**

 * i2400m_bm_cmd - Execute a boot mode command

 *

 * @i2400m: device descriptor

 * @cmd: buffer containing the command data (pointing at the header).

 *     This data can be ANYWHERE (for USB, we will copy it to an

 *     specific buffer). Make sure everything is in proper little
@@ -566,7 +567,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode, 
 *

 * @flags: see I2400M_BM_CMD_* above.

 *

 * @returns: bytes received by the notification; if < 0, an errno code

 * Returns: bytes received by the notification; if < 0, an errno code

 *     denoting an error or:

 *

 *     -ERESTARTSYS  The device has rebooted
@@ -634,8 +635,8 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m, 
 * i2400m_download_chunk - write a single chunk of data to the device's memory

 *

 * @i2400m: device descriptor

 * @buf: the buffer to write

 * @buf_len: length of the buffer to write

 * @chunk: the buffer to write

 * @chunk_len: length of the buffer to write

 * @addr: address in the device memory space

 * @direct: bootrom write mode

 * @do_csum: should a checksum validation be performed
@@ -1533,6 +1534,13 @@ void i2400m_fw_put(struct i2400m_fw *i2400m_fw) 
 * i2400m_dev_bootstrap - Bring the device to a known state and upload firmware

 *

 * @i2400m: device descriptor

 * @flags:

 *      I2400M_BRI_SOFT: a reboot barker has been seen

 *          already, so don't wait for it.

 *

 *      I2400M_BRI_NO_REBOOT: Don't send a reboot command, but wait

 *          for a reboot barker notification. This is a one shot; if

 *          the state machine needs to send a reboot command it will.

 *

 * Returns: >= 0 if ok, < 0 errno code on error.

 *