Commit 57b0c460 authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford
Browse files

IB/srpt: Ensure that modifying the use_srq configfs attribute works 



The use_srq configfs attribute is created after it is read. Hence
modify srpt_tpg_attrib_use_srq_store() such that this function
switches dynamically between non-SRQ and SRQ mode.

Reported-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 8b6dc529

drivers/infiniband/ulp/srpt/ib_srpt.c

+12 −0
Original line number Diff line number Diff line
@@ -3054,7 +3054,9 @@ static ssize_t srpt_tpg_attrib_use_srq_store(struct config_item *item, 
{

	struct se_portal_group *se_tpg = attrib_to_tpg(item);

	struct srpt_port *sport = srpt_tpg_to_sport(se_tpg);

	struct srpt_device *sdev = sport->sdev;

	unsigned long val;

	bool enabled;

	int ret;



	ret = kstrtoul(page, 0, &val);
@@ -3062,7 +3064,17 @@ static ssize_t srpt_tpg_attrib_use_srq_store(struct config_item *item, 
		return ret;

	if (val != !!val)

		return -EINVAL;



	ret = mutex_lock_interruptible(&sdev->mutex);

	if (ret < 0)

		return ret;

	enabled = sport->enabled;

	/* Log out all initiator systems before changing 'use_srq'. */

	srpt_set_enabled(sport, false);

	sport->port_attrib.use_srq = val;

	srpt_use_srq(sdev, sport->port_attrib.use_srq);

	srpt_set_enabled(sport, enabled);

	mutex_unlock(&sdev->mutex);



	return count;

}