Commit 51b74c09 authored by Hans Verkuil's avatar Hans Verkuil
Browse files

media: qcom: venus: fix incorrect return value 



'pd' can be NULL, and in that case it shouldn't be passed to
PTR_ERR. Fixes a smatch warning:

drivers/media/platform/qcom/venus/pm_helpers.c:873 vcodec_domains_get() warn: passing zero to 'PTR_ERR'

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
parent b925fb42

drivers/media/platform/qcom/venus/pm_helpers.c

+1 −1
Original line number Diff line number Diff line
@@ -870,7 +870,7 @@ static int vcodec_domains_get(struct venus_core *core) 
		pd = dev_pm_domain_attach_by_name(dev,

						  res->vcodec_pmdomains[i]);

		if (IS_ERR_OR_NULL(pd))

			return PTR_ERR(pd) ? : -ENODATA;

			return pd ? PTR_ERR(pd) : -ENODATA;

		core->pmdomains[i] = pd;

	}