Commit 43552e6d authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

ARM: dts: exynos: override GPIO keys node by label in Exynos4412 Odroid family 



Using full paths to extend or override a device tree node is error
prone.  If there was a typo error, a new node will be created instead of
extending the existing node.  This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201027170947.132725-4-krzk@kernel.org
parent d918633c

arch/arm/boot/dts/exynos4412-odroid-common.dtsi

+1 −1
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ firmware@204f000 { 
		reg = <0x0204F000 0x1000>;

	};



	gpio_keys {

	gpio_keys: gpio-keys {

		compatible = "gpio-keys";

		pinctrl-names = "default";

		pinctrl-0 = <&gpio_power_key>;

arch/arm/boot/dts/exynos4412-odroidx.dts

+12 −12
Original line number Diff line number Diff line
@@ -36,18 +36,6 @@ led2 { 
		};

	};



	gpio_keys {

		pinctrl-0 = <&gpio_power_key &gpio_home_key>;



		home_key {

			gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;

			linux,code = <KEY_HOME>;

			label = "home key";

			debounce-interval = <10>;

			wakeup-source;

		};

	};



	regulator_p3v3 {

		compatible = "regulator-fixed";

		regulator-name = "p3v3_en";
@@ -76,6 +64,18 @@ &ehci { 
	phy-names = "hsic0";

};



&gpio_keys {

	pinctrl-0 = <&gpio_power_key &gpio_home_key>;



	home-key {

		gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;

		linux,code = <KEY_HOME>;

		label = "home key";

		debounce-interval = <10>;

		wakeup-source;

	};

};



&mshc_0 {

	vqmmc-supply = <&buck8_reg>;

};