Commit 3e8621ab authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman
Browse files

staging: most: usb: remove overcautious parameter checking 



The interface pointer passed to a core API function cannot be NULL. This
patch removes unnessecary the sanity check of the pointer.

Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/1588672829-28883-2-git-send-email-christian.gromm@microchip.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d97a9d7a

drivers/staging/most/usb/usb.c

+3 −8
Original line number Diff line number Diff line
@@ -233,10 +233,6 @@ static int hdm_poison_channel(struct most_interface *iface, int channel) 
	unsigned long flags;

	spinlock_t *lock; /* temp. lock */



	if (unlikely(!iface)) {

		dev_warn(&mdev->usb_device->dev, "Poison: Bad interface.\n");

		return -EIO;

	}

	if (unlikely(channel < 0 || channel >= iface->num_channels)) {

		dev_warn(&mdev->usb_device->dev, "Channel ID out of range.\n");

		return -ECHRNG;
@@ -559,7 +555,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel, 
	unsigned long length;

	void *virt_address;



	if (unlikely(!iface || !mbo))

	if (unlikely(!mbo))

		return -EIO;

	if (unlikely(iface->num_channels <= channel || channel < 0))

		return -ECHRNG;
@@ -674,8 +670,8 @@ static int hdm_configure_channel(struct most_interface *iface, int channel, 
	mdev->clear_work[channel].mdev = mdev;

	INIT_WORK(&mdev->clear_work[channel].ws, wq_clear_halt);



	if (unlikely(!iface || !conf)) {

		dev_err(dev, "Bad interface or config pointer.\n");

	if (unlikely(!conf)) {

		dev_err(dev, "Bad config pointer.\n");

		return -EINVAL;

	}

	if (unlikely(channel < 0 || channel >= iface->num_channels)) {
@@ -747,7 +743,6 @@ static void hdm_request_netinfo(struct most_interface *iface, int channel, 
{

	struct most_dev *mdev;



	BUG_ON(!iface);

	mdev = to_mdev(iface);

	mdev->on_netinfo = on_netinfo;

	if (!on_netinfo)