Commit 321e329b authored by Mike Marciniszyn's avatar Mike Marciniszyn Committed by Doug Ledford
Browse files

IB/srpt: Post receive work requests after qp transition to INIT state 



IB and iWARP specs both spell out that posting a receive work request
to a queue pair in the RESET state is an invalid operation and required
to fail.  Postpone posting receive work requests until after the
transition to the INIT state.

Fixes: commit dea26209 ("IB/srpt: Change default behavior from using SRQ to using RC")
Signed-off-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent ba97b749

drivers/infiniband/ulp/srpt/ib_srpt.c

+4 −4
Original line number Diff line number Diff line
@@ -1687,10 +1687,6 @@ static int srpt_create_ch_ib(struct srpt_rdma_ch *ch) 
		goto err_destroy_cq;

	}



	if (!sdev->use_srq)

		for (i = 0; i < ch->rq_size; i++)

			srpt_post_recv(sdev, ch, ch->ioctx_recv_ring[i]);



	atomic_set(&ch->sq_wr_avail, qp_init->cap.max_send_wr);



	pr_debug("%s: max_cqe= %d max_sge= %d sq_size = %d cm_id= %p\n",
@@ -1701,6 +1697,10 @@ static int srpt_create_ch_ib(struct srpt_rdma_ch *ch) 
	if (ret)

		goto err_destroy_qp;



	if (!sdev->use_srq)

		for (i = 0; i < ch->rq_size; i++)

			srpt_post_recv(sdev, ch, ch->ioctx_recv_ring[i]);



out:

	kfree(qp_init);

	return ret;