Commit 28675d45 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven
Browse files

drm: renesas: shmobile: Fix overlay plane disable 



Merely writing zero to the CHn Source Image Format Register is not
sufficient to disable a plane, as the programmed register value is not
propagated immediately to the current side.  This can be seen when using
the -P option of modetest: the extra plane is displayed correctly, but
does not disappear after exit.

Fix this by doing the full update dance using the Blend Control
Register, like is done when enabling the plane.

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/54e2556e18b5524ce153a7ac79faf2c7b0a55260.1694767209.git.geert+renesas@glider.be
parent c68ab8b5

drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c

+3 −0
Original line number Diff line number Diff line
@@ -215,7 +215,10 @@ static int shmob_drm_plane_disable(struct drm_plane *plane, 


	splane->format = NULL;



	lcdc_write(sdev, LDBCR, LDBCR_UPC(splane->index));

	lcdc_write(sdev, LDBnBSIFR(splane->index), 0);

	lcdc_write(sdev, LDBCR,

		   LDBCR_UPF(splane->index) | LDBCR_UPD(splane->index));

	return 0;

}