Commit 24940373 authored Nov 23, 2020 by Lee Jones Committed by Alex Deucher Nov 24, 2020

drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'addr' not described in 'si_dma_ring_emit_fence'
drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'seq' not described in 'si_dma_ring_emit_fence'
drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'flags' not described in 'si_dma_ring_emit_fence'
drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Excess function parameter 'fence' description in 'si_dma_ring_emit_fence'
drivers/gpu/drm/amd/amdgpu/si_dma.c:252: warning: Function parameter or member 'timeout' not described in 'si_dma_ring_test_ib'
drivers/gpu/drm/amd/amdgpu/si_dma.c:408: warning: Function parameter or member 'ring' not described in 'si_dma_ring_pad_ib'
drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Function parameter or member 'vmid' not described in 'si_dma_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Function parameter or member 'pd_addr' not described in 'si_dma_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Excess function parameter 'vm' description in 'si_dma_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Function parameter or member 'ib' not described in 'si_dma_emit_copy_buffer'
drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Function parameter or member 'tmz' not described in 'si_dma_emit_copy_buffer'
drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Excess function parameter 'ring' description in 'si_dma_emit_copy_buffer'
drivers/gpu/drm/amd/amdgpu/si_dma.c:804: warning: Function parameter or member 'ib' not described in 'si_dma_emit_fill_buffer'
drivers/gpu/drm/amd/amdgpu/si_dma.c:804: warning: Excess function parameter 'ring' description in 'si_dma_emit_fill_buffer'

Acked-by: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent d14f279a

drivers/gpu/drm/amd/amdgpu/si_dma.c

+10 −4

Original line number	Diff line number	Diff line
		@@ -81,7 +81,9 @@ static void si_dma_ring_emit_ib(struct amdgpu_ring *ring,
		* si_dma_ring_emit_fence - emit a fence on the DMA ring
		*
		* @ring: amdgpu ring pointer
		* @fence: amdgpu fence object
		* @addr: address
		* @seq: sequence number
		* @flags: fence related flags
		*
		* Add a DMA fence packet to the ring to write
		* the fence seq number and DMA trap packet to generate
		@@ -244,6 +246,7 @@ static int si_dma_ring_test_ring(struct amdgpu_ring *ring)
		* si_dma_ring_test_ib - test an IB on the DMA engine
		*
		* @ring: amdgpu_ring structure holding ring information
		* @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT
		*
		* Test a simple IB in the DMA ring (VI).
		* Returns 0 on success, error on failure.
		@@ -401,6 +404,7 @@ static void si_dma_vm_set_pte_pde(struct amdgpu_ib *ib,
		/**
		* si_dma_pad_ib - pad the IB to the required number of dw
		*
		* @ring: amdgpu_ring pointer
		* @ib: indirect buffer to fill with padding
		*
		*/
		@@ -436,7 +440,8 @@ static void si_dma_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
		* si_dma_ring_emit_vm_flush - cik vm flush using sDMA
		*
		* @ring: amdgpu_ring pointer
		* @vm: amdgpu_vm pointer
		* @vmid: vmid number to use
		* @pd_addr: address
		*
		* Update the page table base and flush the VM TLB
		* using sDMA (VI).
		@@ -764,10 +769,11 @@ static void si_dma_set_irq_funcs(struct amdgpu_device *adev)
		/**
		* si_dma_emit_copy_buffer - copy buffer using the sDMA engine
		*
		* @ring: amdgpu_ring structure holding ring information
		* @ib: indirect buffer to copy to
		* @src_offset: src GPU address
		* @dst_offset: dst GPU address
		* @byte_count: number of bytes to xfer
		* @tmz: is this a secure operation
		*
		* Copy GPU buffers using the DMA engine (VI).
		* Used by the amdgpu ttm implementation to move pages if
		@@ -790,7 +796,7 @@ static void si_dma_emit_copy_buffer(struct amdgpu_ib *ib,
		/**
		* si_dma_emit_fill_buffer - fill buffer using the sDMA engine
		*
		* @ring: amdgpu_ring structure holding ring information
		* @ib: indirect buffer to copy to
		* @src_data: value to write to buffer
		* @dst_offset: dst GPU address
		* @byte_count: number of bytes to xfer