Commit 183c3237 authored by OGAWA Hirofumi's avatar OGAWA Hirofumi Committed by Andrew Morton
Browse files

fat: add ratelimit to fat*_ent_bread() 

fat*_ent_bread() can be the cause of too many report on I/O error path. 
So use fat_msg_ratelimit() instead.

Link: https://lkml.kernel.org/r/87bkxogfeq.fsf@mail.parknet.co.jp


Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Reported-by: default avatarqianfan <qianfanguijin@163.com>
Tested-by: default avatarqianfan <qianfanguijin@163.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent e057aaec

fs/fat/fatent.c

+4 −3
Original line number Diff line number Diff line
@@ -94,7 +94,8 @@ static int fat12_ent_bread(struct super_block *sb, struct fat_entry *fatent, 
err_brelse:

	brelse(bhs[0]);

err:

	fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", (llu)blocknr);

	fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)",

			  (llu)blocknr);

	return -EIO;

}
@@ -107,7 +108,7 @@ static int fat_ent_bread(struct super_block *sb, struct fat_entry *fatent, 
	fatent->fat_inode = MSDOS_SB(sb)->fat_inode;

	fatent->bhs[0] = sb_bread(sb, blocknr);

	if (!fatent->bhs[0]) {

		fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)",

		fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)",

				  (llu)blocknr);

		return -EIO;

	}