Commit 153167c5 authored by Deepak R Varma's avatar Deepak R Varma Committed by Greg Kroah-Hartman
Browse files

staging: comedi: tests: Simplify conditional evaluation 



Boolean comparison of the condition inside unittest function is
unnecessary and can be simplified by directly using the condition
outcome for evaluation. Issue reported by :
scripts/coccinelle/misc/boolinit.cocci

Signed-off-by: default avatarDeepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/20201019171426.GA72818@ubuntu204


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a5a6e5ef

drivers/staging/comedi/drivers/tests/ni_routes_test.c

+4 −4
Original line number Diff line number Diff line
@@ -499,13 +499,13 @@ void test_route_register_is_valid(void) 
	const struct ni_route_tables *T = &private.routing_tables;



	init_pci_fake();

	unittest(route_register_is_valid(4, O(4), T) == false,

	unittest(!route_register_is_valid(4, O(4), T),

		 "check for bad source 4-->4\n");

	unittest(route_register_is_valid(0, O(1), T) == true,

	unittest(route_register_is_valid(0, O(1), T),

		 "find first source\n");

	unittest(route_register_is_valid(4, O(6), T) == true,

	unittest(route_register_is_valid(4, O(6), T),

		 "find middle source\n");

	unittest(route_register_is_valid(9, O(8), T) == true,

	unittest(route_register_is_valid(9, O(8), T),

		 "find last source");

}