Commit 1080782f authored by Bodo Stroesser's avatar Bodo Stroesser Committed by Martin K. Petersen
Browse files

scsi: target: tcmu: Use GFP_NOIO while handling cmds or holding cmdr_lock 

Especially when using tcmu with tcm_loop, memory allocations with
GFP_KERNEL for a LUN can cause write back to the same LUN.

So we have to use GFP_NOIO when allocation is done while handling commands
or while holding cmdr_lock.

Link: https://lore.kernel.org/r/20210305190009.32242-1-bostroesser@gmail.com


Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarBodo Stroesser <bostroesser@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f7c89771

drivers/target/target_core_user.c

+2 −2
Original line number Diff line number Diff line
@@ -518,7 +518,7 @@ static inline int tcmu_get_empty_block(struct tcmu_dev *udev, 
		if (!page)

			goto err_alloc;



		if (xa_store(&udev->data_blocks, dbi, page, GFP_KERNEL))

		if (xa_store(&udev->data_blocks, dbi, page, GFP_NOIO))

			goto err_insert;

	}
@@ -1272,7 +1272,7 @@ tcmu_tmr_notify(struct se_device *se_dev, enum tcm_tmreq_table tmf, 
	pr_debug("TMR event %d on dev %s, aborted cmds %d, afflicted cmd_ids %d\n",

		 tcmu_tmr_type(tmf), udev->name, i, cmd_cnt);



	tmr = kmalloc(sizeof(*tmr) + cmd_cnt * sizeof(*cmd_ids), GFP_KERNEL);

	tmr = kmalloc(sizeof(*tmr) + cmd_cnt * sizeof(*cmd_ids), GFP_NOIO);

	if (!tmr)

		goto unlock;