Commit 050a6f34 authored by Ohad Sharabi's avatar Ohad Sharabi Committed by Greg Kroah-Hartman
Browse files

habanalabs: add user API to get valid DRAM page sizes 



Future devices will support multiple device memory page sizes.
In addition, an API for the user was added for it to be able to control
the device memory allocation page size.

This patch is a complementary patch to inform the user of the available
page size supported by the device.

Signed-off-by: default avatarOhad Sharabi <osharabi@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 06926dbe

drivers/misc/habanalabs/common/habanalabs.h

+2 −0
Original line number Diff line number Diff line
@@ -1304,6 +1304,7 @@ struct fw_load_mgr { 
 * @get_stream_master_qid_arr: get pointer to stream masters QID array

 * @is_valid_dram_page_size: return true if page size is supported in device

 *                           memory allocation, otherwise false.

 * @get_valid_dram_page_orders: get valid device memory allocation page orders

 */

struct hl_asic_funcs {

	int (*early_init)(struct hl_device *hdev);
@@ -1432,6 +1433,7 @@ struct hl_asic_funcs { 
	bool (*is_valid_dram_page_size)(u32 page_size);

	int (*mmu_get_real_page_size)(struct hl_device *hdev, struct hl_mmu_properties *mmu_prop,

					u32 page_size, u32 *real_page_size, bool is_dram_addr);

	void (*get_valid_dram_page_orders)(struct hl_info_dev_memalloc_page_sizes *info);

};

drivers/misc/habanalabs/common/habanalabs_ioctl.c

+24 −0
Original line number Diff line number Diff line
@@ -591,6 +591,27 @@ static int razwi_info(struct hl_fpriv *hpriv, struct hl_info_args *args) 
	return copy_to_user(out, &info, min_t(size_t, max_size, sizeof(info))) ? -EFAULT : 0;

}



static int dev_mem_alloc_page_sizes_info(struct hl_fpriv *hpriv, struct hl_info_args *args)

{

	void __user *out = (void __user *) (uintptr_t) args->return_pointer;

	struct hl_info_dev_memalloc_page_sizes info = {0};

	struct hl_device *hdev = hpriv->hdev;

	u32 max_size = args->return_size;



	if ((!max_size) || (!out))

		return -EINVAL;



	/*

	 * Future ASICs that will support multiple DRAM page sizes will support only "powers of 2"

	 * pages (unlike some of the ASICs before supporting multiple page sizes).

	 * For this reason for all ASICs that not support multiple page size the function will

	 * return an empty bitmask indicating that multiple page sizes is not supported.

	 */

	hdev->asic_funcs->get_valid_dram_page_orders(&info);



	return copy_to_user(out, &info, min_t(size_t, max_size, sizeof(info))) ? -EFAULT : 0;

}



static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,

				struct device *dev)

{
@@ -641,6 +662,9 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data, 
	case HL_INFO_RAZWI_EVENT:

		return razwi_info(hpriv, args);



	case HL_INFO_DEV_MEM_ALLOC_PAGE_SIZES:

		return dev_mem_alloc_page_sizes_info(hpriv, args);



	default:

		break;

	}

drivers/misc/habanalabs/gaudi/gaudi.c

+7 −0
Original line number Diff line number Diff line
@@ -9378,6 +9378,12 @@ static u32 *gaudi_get_stream_master_qid_arr(void) 
	return gaudi_stream_master;

}



static void gaudi_get_valid_dram_page_orders(struct hl_info_dev_memalloc_page_sizes *info)

{

	/* set 0 since multiple pages are not supported */

	info->page_order_bitmask = 0;

}



static ssize_t infineon_ver_show(struct device *dev, struct device_attribute *attr, char *buf)

{

	struct hl_device *hdev = dev_get_drvdata(dev);
@@ -9489,6 +9495,7 @@ static const struct hl_asic_funcs gaudi_funcs = { 
	.get_stream_master_qid_arr = gaudi_get_stream_master_qid_arr,

	.is_valid_dram_page_size = NULL,

	.mmu_get_real_page_size = hl_mmu_get_real_page_size,

	.get_valid_dram_page_orders = gaudi_get_valid_dram_page_orders,

};



/**

drivers/misc/habanalabs/goya/goya.c

+7 −0
Original line number Diff line number Diff line
@@ -5679,6 +5679,12 @@ static u32 *goya_get_stream_master_qid_arr(void) 
	return NULL;

}



static void goya_get_valid_dram_page_orders(struct hl_info_dev_memalloc_page_sizes *info)

{

	/* set 0 since multiple pages are not supported */

	info->page_order_bitmask = 0;

}



static const struct hl_asic_funcs goya_funcs = {

	.early_init = goya_early_init,

	.early_fini = goya_early_fini,
@@ -5767,6 +5773,7 @@ static const struct hl_asic_funcs goya_funcs = { 
	.get_stream_master_qid_arr = goya_get_stream_master_qid_arr,

	.is_valid_dram_page_size = NULL,

	.mmu_get_real_page_size = hl_mmu_get_real_page_size,

	.get_valid_dram_page_orders = goya_get_valid_dram_page_orders,

};



/*

include/uapi/misc/habanalabs.h

+37 −26
Original line number Diff line number Diff line
@@ -348,6 +348,7 @@ enum hl_server_type { 
 *                            The address which accessing it caused the razwi.

 *                            Razwi initiator.

 *                            Razwi cause, was it a page fault or MMU access error.

 * HL_INFO_DEV_MEM_ALLOC_PAGE_SIZES - Retrieve valid page sizes for device memory allocation

 */

#define HL_INFO_HW_IP_INFO			0

#define HL_INFO_HW_EVENTS			1
@@ -372,6 +373,7 @@ enum hl_server_type { 
#define HL_INFO_LAST_ERR_OPEN_DEV_TIME		23

#define HL_INFO_CS_TIMEOUT_EVENT		24

#define HL_INFO_RAZWI_EVENT			25

#define HL_INFO_DEV_MEM_ALLOC_PAGE_SIZES	26



#define HL_INFO_VERSION_MAX_LEN			128

#define HL_INFO_CARD_NAME_MAX_LEN		16
@@ -643,6 +645,15 @@ struct hl_info_razwi_event { 
	__u8 pad[2];

};



/**

 * struct hl_info_dev_memalloc_page_sizes - valid page sizes in device mem alloc information.

 * @page_order_bitmask: bitmap in which a set bit represents the order of the supported page size

 *                      (e.g. 0x2100000 means that 1MB and 32MB pages are supported).

 */

struct hl_info_dev_memalloc_page_sizes {

	__u64 page_order_bitmask;

};



enum gaudi_dcores {

	HL_GAUDI_WS_DCORE,

	HL_GAUDI_WN_DCORE,